Skip to content

SKE Credentials Rotation: deprecate old commands improvements #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DiogoFerrao merged 2 commits into from
Apr 3, 2024
Merged

SKE Credentials Rotation: deprecate old commands improvements #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d590489
remove example cluster name from deprecation message
DiogoFerrao Apr 3, 2024
9084246
address comments
DiogoFerrao Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/cmd/ske/credentials/describe/describe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ func NewCmd() *cobra.Command {
Deprecated: fmt.Sprintf("%s\n%s\n%s\n%s\n",
"and will be removed in a future release.",
"Please use the following command to obtain a kubeconfig file instead:",
" $ stackit ske kubeconfig create my-cluster",
" $ stackit ske kubeconfig create CLUSTER_NAME",
"For more information, visit: https://docs.stackit.cloud/stackit/en/how-to-rotate-ske-credentials-200016334.html",
),
Example: examples.Build(
Expand Down
4 changes: 2 additions & 2 deletions internal/cmd/ske/credentials/rotate/rotate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ func NewCmd() *cobra.Command {
Deprecated: fmt.Sprintf("%s\n%s\n%s\n%s\n%s\n",
"and will be removed in a future release.",
"Please use the 2-step credential rotation flow instead, by running the commands:",
" $ stackit ske credentials start-rotation my-cluster",
" $ stackit ske credentials complete-rotation my-cluster",
" $ stackit ske credentials start-rotation CLUSTER_NAME",
" $ stackit ske credentials complete-rotation CLUSTER_NAME",
"For more information, visit: https://docs.stackit.cloud/stackit/en/how-to-rotate-ske-credentials-200016334.html",
),
Example: examples.Build(
Expand Down