Fix bugs found while testing file-based state tracking - #1347
Merged
Conversation
dmjb
changed the title
dmjb
force-pushed
the
enable-state-files
branch
2 times, most recently
from
August 12, 2025 09:30
dd16ce4 to
bcf1e06
Compare
dmjb
changed the title
dmjb
force-pushed
the
enable-state-files
branch
from
August 12, 2025 10:45
65107ab to
519df60
Compare
dmjb
marked this pull request as ready for review
August 12, 2025 10:59
This PR was intended to enable file-based state tracking. However, I found some bugs during testing which involves touching many files, so this PR addresses these bugs without enabling file-based state tracking. 1. I discovered that I left out a call to change the state to "running" once the proxy-runner is ready. Simply adding the state manager type led to a circular dependency, which required a bunch of refactoring of code. This is responsible for most of the diff here. 2. The code which created the base directory for the status files was using the wrong path - this was fixed. 3. I originally had separate methods for creating the initial status, and updating. This led to problems with the detached process flow (which would try to create the status twice, leading to an error). This PR changes the code to use a single method which creates or update.
dmjb
force-pushed
the
enable-state-files
branch
from
August 12, 2025 11:03
427576c to
3e07dd9
Compare
JAORMX
approved these changes
Aug 12, 2025
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was intended to enable file-based state tracking. However, I found some bugs during testing which involves touching many files, so this PR addresses these bugs without enabling file-based state tracking.