Skip to content

Fix test, don't delete docker config #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mclasmeier merged 1 commit into from
Mar 25, 2026
Merged

Fix test, don't delete docker config #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 4 additions & 22 deletions internal/dockerauth/dockerauth_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,8 @@ import (

func TestGetAndVerifyCredentialsFromEnv(t *testing.T) {
// Set environment variables for test
os.Setenv("REGISTRY_USERNAME", "user")
os.Setenv("REGISTRY_PASSWORD", "pass")
defer func() {
os.Unsetenv("REGISTRY_USERNAME")
os.Unsetenv("REGISTRY_PASSWORD")
}()
t.Setenv("REGISTRY_USERNAME", "user")
t.Setenv("REGISTRY_PASSWORD", "pass")

log := logger.New()
da := New(log)
Expand Down Expand Up @@ -87,22 +83,8 @@ func TestGetAndVerifyCredentialsNoCredentials(t *testing.T) {
os.Unsetenv("REGISTRY_USERNAME")
os.Unsetenv("REGISTRY_PASSWORD")

// Remove docker config if it exists (temporarily)
homeDir, _ := os.UserHomeDir()
dockerConfigPath := homeDir + "/.docker/config.json"
var backupConfig []byte
var configExisted bool

if data, err := os.ReadFile(dockerConfigPath); err == nil {
backupConfig = data
configExisted = true
os.Remove(dockerConfigPath)
}
defer func() {
if configExisted {
os.WriteFile(dockerConfigPath, backupConfig, 0644)
}
}()
// Use a temporary home directory to simulate missing credentials.
t.Setenv("HOME", t.TempDir())

log := logger.New()
da := New(log)
Expand Down
Loading