Skip to content

chore(ci): remove apollo-ci images#3303

Merged
BradLugo merged 1 commit into
masterfrom
blugo/remove-apollo-images
Jun 26, 2026
Merged

chore(ci): remove apollo-ci images#3303
BradLugo merged 1 commit into
masterfrom
blugo/remove-apollo-images

Conversation

@BradLugo

@BradLugo BradLugo commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

As of Go 1.21, go will automatically download and use the specified toolchain version if the currently installed Go is older (behavior is configurable with GOTOOLCHAIN).

These changes bring scanner V2's GitHub Actions build process more in line with stackrox's.

Note that the db-integration-tests job still requires quay.io/stackrox-io/apollo-ci:scanner-test.

@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 89858143-8a2d-407a-b188-bbe33f09bc03

📥 Commits

Reviewing files that changed from the base of the PR and between 95637fa and 2d2ec99.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml
💤 Files with no reviewable changes (1)
  • .github/workflows/ci.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated the CI workflow so several jobs now run directly on the GitHub-hosted Ubuntu runner instead of using a separate container.
    • This simplifies the pipeline setup for build, test, and artifact-related jobs without changing their step behavior.

Walkthrough

The CI workflow removes job-level container declarations from multiple jobs, so those steps now run directly on the GitHub-hosted runner.

Changes

CI runner environment

Layer / File(s) Summary
Validation jobs
.github/workflows/ci.yaml
The pre-build, style-check, and unit-test jobs no longer declare the container image.
Artifact generation jobs
.github/workflows/ci.yaml
The dump, bundle, image build, manifest push, and diff-dump jobs no longer declare the container image.
Upload jobs
.github/workflows/ci.yaml
The db-dump, downstream upload, and embedding upload jobs no longer declare the container image.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: removing apollo-ci container images from the CI workflow.
Description check ✅ Passed The description is related to the CI workflow changes and the remaining db-integration-tests container use.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch blugo/remove-apollo-images

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@BradLugo BradLugo force-pushed the blugo/remove-apollo-images branch 2 times, most recently from 71b34e2 to dd0dfad Compare June 26, 2026 07:45
@BradLugo BradLugo changed the base branch from master to blugo/update-golangci-lint-config June 26, 2026 07:45
@BradLugo BradLugo changed the base branch from blugo/update-golangci-lint-config to master June 26, 2026 08:32
@BradLugo BradLugo force-pushed the blugo/remove-apollo-images branch from dd0dfad to 2d2ec99 Compare June 26, 2026 08:35
@BradLugo BradLugo marked this pull request as ready for review June 26, 2026 08:48
@BradLugo BradLugo requested a review from a team as a code owner June 26, 2026 08:48
@BradLugo BradLugo merged commit f7ba5be into master Jun 26, 2026
37 checks passed
@BradLugo BradLugo deleted the blugo/remove-apollo-images branch June 26, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants