**DNM** Test fixes for nigtlies.#21454
Draft
msugakov wants to merge 14 commits into
Draft
Conversation
Otherwise what's the point of having them?
and not just nightlies so that we have coverage for RCs and release tags.
otherwise the latter one is just redundant.
at the job level. Less duplication, less noise.
leads to double-slash in concatenated path. Not a big deal but Tomek did not like it #19303 (comment)
These tests are rather expensive and triggering them on every label change (when `if` conditions are passing) seems like a waste. However, I found that the jobs remain skipped after I add the label and re-run the job or the workflow manually. Have to add `labeled` activation to avoid unintuitive behavior.
To contain costs in case of frequent pushes and/or label changes.
Unfortunately, there's no even smaller one.
Thanks to Claude suggestions, this approach now should not react on any labels but the desired ones and should not cancel running expensive jobs if the run would not actually match the condition.
I think, this got copied over from my original PR and I don't remember why I waited only for a few images. Maybe thought to add it later but never did.
|
Skipping CI for Draft Pull Request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## misha/update-gha-e2e-tests #21454 +/- ##
==============================================================
- Coverage 50.07% 50.07% -0.01%
==============================================================
Files 2837 2837
Lines 217608 217577 -31
==============================================================
- Hits 108969 108945 -24
+ Misses 100727 100725 -2
+ Partials 7912 7907 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
🚀 Build Images ReadyImages are ready for commit 414be2d. To use with deploy scripts: export MAIN_IMAGE_TAG=4.12.x-348-g414be2dc3b |
msugakov
added
e2e-db-backup-restore-test
msugakov
force-pushed
the
misha/update-gha-e2e-tests
branch
from
3d1e9cc to
75471ac
Compare
msugakov
force-pushed
the
misha/fix-nightlies
branch
from
38806b7 to
22a1a39
Compare
msugakov
force-pushed
the
misha/fix-nightlies
branch
from
22a1a39 to
1efb53e
Compare
`MAIN_IMAGE_TAG` controls which images will be used for deployment. `BUILD_TAG` controls the version which `roxctl`, once built, will report about itself. If local `roxctl` reports different version than the test/deployment script expects, the script will try to run `roxctl` from a container. There's likely somehting incompatible with `docker` in GHA and the permissions of the runner which may not be simply fixed without changes to our customer-facing scripts. Instead of looking for a solution there, I make the `BUILD_TAG` be the same as `MAIN_IMAGE_TAG` which prevents `roxctl` to be ran in container - the one is already available as local build.
msugakov
force-pushed
the
misha/fix-nightlies
branch
from
59ae471 to
7761482
Compare
msugakov
changed the title
and whether it fails the same way.
msugakov
force-pushed
the
misha/fix-nightlies
branch
from
7761482 to
414be2d
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #21443.
Not to be merged.
I override
MAIN_IMAGE_TAGhere and I evidenced that this earlier resulted in the same failures as seen in nightlies. See thread under https://redhat-internal.slack.com/archives/C0321S70YK1/p1782139688440169As it's rebased on top of recent #21443, the tests here shouldn't fail that way.