[6.x] Change how the slot with the "customize columns" works. Instead of an…#14885
Merged
Conversation
… absolutely positioned element it now fits within the parent layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Problem
Currently, the "Customize Columns" button is absolutely positioned to the right.
It's positioned absolutely in case there are many custom filters, which would otherwise push the "Customize Columns" button off screen, like in this example, where the numerous filters overflow underneath the control:
This is OK, but it's a fragile solution when we want to pin more buttons in the same space as "Customize columns".
I found that extra buttons now clash with the filter overflow, like this:
What this PR Does
Makes the layout less hacky by positioning the "Customize Columns" button within the parent flexbox layout
(After) you can see the filters now fade out as they overflow in the flexbox layout, rather than flowing underneath the buttons to the right
If we inspect the DOM we can now see the right icons are part of the parent flex layout, including a gap
How to Reproduce