Fix contract extend panic when extending a missing entry - #2657
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents contract extend from panicking when the target ledger entry is missing.
Changes:
- Safely handles empty ledger-entry responses.
- Adds integration coverage for the regression.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
cmd/soroban-cli/src/commands/contract/extend.rs |
Returns LedgerEntryNotFound instead of indexing an empty vector. |
cmd/crates/soroban-test/tests/it/integration/hello_world.rs |
Verifies a missing entry produces a clean error without panic output. |
fnando
enabled auto-merge (squash)
July 27, 2026 17:11
leighmcculloch
added a commit
that referenced
this pull request
Jul 28, 2026
### What Guard `stellar contract restore` against the same "index out of bounds" panic that #2657 fixed in `extend`: the no-op path unconditionally indexed `entry.entries[0]`, which panics if the post-transaction fetch returns no entries. It now errors with "Ledger entry not found" instead. ### Why `restore` carried the identical unguarded indexing as `extend` (see #2599), so this applies the same `.first().ok_or(Error::LedgerEntryNotFound)?` fix. Unlike extend, restoring a non-existent entry fails cleanly at simulation ("Missing entry to restore") before reaching the no-op path, so this guard is defensive hardening for the narrower case where the fetch after a no-op comes back empty (e.g. the entry was evicted in the meantime). The regression test asserts the non-existent-entry case fails cleanly at simulation without panicking. ### Known limitations The empty-fetch-after-no-op case itself isn't covered by an integration test since simulation catches the straightforward missing-entry scenario first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes a panic in
stellar contract extend. When run against a well-formed but non-existent contract entry, the transaction goes through as a no-op and the CLI then crashes withindex out of bounds: the len is 0 but the index is 0. It now exits cleanly with a "Ledger entry not found" error instead.Why
On a no-op extend the code fetched the ledger entries and unconditionally indexed
entry.entries[0]. For a non-existent entry that vec is empty, so the index panicked. This replaces the raw index with.first().ok_or(Error::LedgerEntryNotFound)?, reusing the existing error variant already returned for the analogous no-op cases in the same function. Fixes #2599.Known limitations
N/A