Repository navigation
Poll fee bumps by the inner transaction hash, and check the ledger before rebuilding a transaction - #3169
Open
tamirms wants to merge 2 commits into
Open
Poll fee bumps by the inner transaction hash, and check the ledger before rebuilding a transaction#3169tamirms wants to merge 2 commits into
tamirms wants to merge 2 commits into
Conversation
Any fee-bump transaction of an inner transaction can get it into the ledger, so the fee-bump guide's examples now poll the inner transaction hash, which Stellar RPC and Horizon both find in any fee bump. The replace-by-fee section says so. The Horizon error-handling page says to poll a fee bump by its inner hash, and adds a section on checking the ledger before rebuilding a transaction with a new sequence number. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Contributor
|
/triage |
A transaction found by hash with successful false used its sequence number but none of its operations took effect, so it can be rebuilt. A sequence number can also be passed by a bump-sequence operation or a minSeqNum precondition, not only by a transaction with that number.
Contributor
|
🤖 Automated message from Doxie. Reviewing because @kaankacar asked with /triage. Verified: RPC and Horizon both find a fee bump by its inner hash, on testnet and in source. I pushed one fix: step 3 of "Before Rebuilding a Transaction" now allows a rebuild when the original failed ( Not run: the JavaScript, Python, Go, and Java examples (this lane runs no PR code). I read the hash calls against SDK sources. Ready to merge. What I checked
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any fee-bump transaction of an inner transaction can get it into the ledger, not only the one you submitted. So the fee-bump guide's examples (JavaScript, Python, Go and Java) now poll the inner transaction hash, which Stellar RPC's
getTransactionand Horizon'sGET /transactions/:transaction_hashboth find in any fee bump. The replace-by-fee section explains why. The Java example used to say that a fee-bump transaction can't be found by its inner hash; both APIs do find it.The Horizon error-handling page now says to poll a fee-bump transaction by its inner hash. It also adds a "Before Rebuilding a Transaction" section: before you rebuild a transaction with a new sequence number, compare the source account's sequence number with the original transaction's, and look the original up by hash. The submission and sequence-number sections link to it.
🤖 Generated with Claude Code