This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Jan 5, 2023. It is now read-only.
oneOf smart knob returns "--" as value of empty option #30
Description
if one set the defaultProp of an oneOf as "" instead of "--" the Story Source will show the option after selecting the option and the select the empty value again. Also Jest is complaining about this.
See the option "state":
<Radio
label="Radio"
id="radioId"
testid="radioId"
onChange={onChange}
onBlur={onBlur}
onFocus={onFocus}
state="--"
/>
<Radio
label="Radio"
id="radioId"
testid="radioId"
onChange={onChange}
onBlur={onBlur}
onFocus={onFocus}
/>
Radio.defaultProps = {
state: "",
};
Radio.propTypes = {
state: PropTypes.oneOf(["success", "warning", "error"]),
}
My solution for now is to ad an "" to the oneOf
Radio.propTypes = {
state: PropTypes.oneOf(["", "success", "warning", "error"]),
}
Activity