This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Smartknobs is not showing up, what am I missing? #37
Description
Currently
I'm taking the example provided in the README.md adding on it import '@storybook/addon-actions' or gonna fail asking for it.
import React, { PropTypes } from 'react'
import { storiesOf } from '@storybook/react'
import { withKnobs } from '@storybook/addon-knobs'
import '@storybook/addon-actions';
import { withSmartKnobs } from 'storybook-addon-smart-knobs'
const Button = ({ children, onClick }) => (
<button onClick={ onClick }>{ children }</button>
)
Button.propTypes = {
children: PropTypes.node,
onClick: PropTypes.func
}
storiesOf('Button')
.addDecorator(withSmartKnobs)
.addDecorator(withKnobs)
.add('simple', () => <Button>Smart knobed button</Button>)
Here's my package.json dep and devDep
"dependencies": {
"prop-types": "^15.6.2",
"react": "^16.6.3",
"react-dom": "^16.6.3"
},
"devDependencies": {
"@babel/core": "^7.2.0",
"@storybook/addon-actions": "^4.0.12",
"@storybook/addon-knobs": "^4.0.12",
"@storybook/react": "^4.0.12",
"babel-loader": "^8.0.4",
"storybook-addon-smart-knobs": "^3.3.1"
}
Issue
Activity
mahmoud-zakria-sociomantic commentedon Dec 11, 2018
Used
import PropTypes from prop-typesinstead ofreactsolved it, but no addon/propValues controllers show up.Also you need to add
moduleas a second argument ofstoriesOfor you will loseHMRfunctionality.ndelangen commentedon Dec 12, 2018
You didn't register the addon(s).
In order to use smart knobs, you have to be using knobs, which needs to be registered:
https://github.com/storybooks/storybook/tree/next/addons/knobs#getting-started
mahmoud-zakria-sociomantic commentedon Dec 13, 2018
I've already registered it in
.storybook/addons.js, but nothing.Here are my screenshots
And here's my code
Note: I'm usingBabel7.ndelangen commentedon Dec 13, 2018
I published 4.0.0
I upgraded all dependencies to the latest
This package is now storybook 4.x.x compatible.
I'm assuming the problem you were facing was a mismatch of versions, since you code you posted is fine.
Please let me know if this resolves the issue 👌
mahmoud-zakria-sociomantic commentedon Dec 13, 2018
Thanks man, but no :( :(.
ndelangen commentedon Dec 13, 2018
@mahmoud-zakria-sociomantic if you run the storybook in this repo, does it show up then?
What differences are there between the example in this repo and your setup?
mahmoud-zakria-sociomantic commentedon Dec 13, 2018
@ndelangen
No, I'm taking the whole example without putting any code of mine.
Does it work for you?
mahmoud-zakria-sociomantic commentedon Dec 13, 2018
Renamed to Smartknobs is not showing up
[-]Can't read property 'node' of undefined msg[/-][+]Smartknobs is not showing up[Renamed][/+]ndelangen commentedon Dec 13, 2018
Yeah the example in the codebase is working on my machine.. 😕
ndelangen commentedon Dec 14, 2018
@mahmoud-zakria-sociomantic Can you share a repo that has this problem so I can debug?
mahmoud-zakria-sociomantic commentedon Dec 14, 2018
@ndelangen Sure, here it's
https://github.com/mahmoud-zakria-sociomantic/nessiestorybook
mahmoud-zakria-sociomantic commentedon Dec 14, 2018
Node version: 8.11.4
Yarn version: 1.7
OS: macOS High Sierra v10
mahmoud-zakria-sociomantic commentedon Dec 17, 2018
@ndelangen Is it working with you?
mahmoud-zakria-sociomantic commentedon Dec 19, 2018
@ndelangen , I've tried the below updates and still no knobs
"@storybook/addon-actions": "^4.1.2",
"@storybook/addon-knobs": "^4.1.2",
"@storybook/react": "^4.1.2",
"babel-loader": "^8.0.4",
"storybook-addon-smart-knobs": "^4.1.0"
1 remaining item
melMass commentedon Jan 10, 2019
This should be in the readme
melMass commentedon Jan 10, 2019
I'm getting:
mahmoud-zakria-sociomantic commentedon Jan 14, 2019
@melMass it has to be
import '@storybook/addon-knobs/register';[-]Smartknobs is not showing up[Renamed][/-][+]Smartknobs is not showing up[/+][-]Smartknobs is not showing up[/-][+]Smartknobs is not showing up, what am I missing?[/+]azz0r commentedon Feb 1, 2019
Also getting this issue but no errors that allude to a problem
mahmoud-zakria-sociomantic commentedon Feb 1, 2019
@azz0r I'm following them on Slack they are going to handle it after releasing v5.
https://storybooks.slack.com/archives/C1ZN32SKW/p1547805319034200
anand-neema commentedon Feb 24, 2019
@mahmoud-zakria-sociomantic Is there any estimation on resolving this issue ? And when they are planning for V5
shilman commentedon Feb 24, 2019
We're scheduled to release v5 in a week or so but there will be a lot of v5 support after the release and we've pushed a lot to post-v5 so frankly I wouldn't wait on this. AFAIK plain knobs are working great
ndelangen commentedon Feb 24, 2019
PLain knobs IS working, this code in the addon is working, it's the generation of the needed data from propTypes/ types that is not working and causing the knobs to not show up.
anand-neema commentedon Apr 18, 2019
@shilman is there any estimation to resolve this issue ? So that all nobs will work on the basis of proptypes/flowTypes
can you please update the planning to fix this , so that we can proceed accordingly .
shilman commentedon Apr 18, 2019
like i said above,
addon-knobsis working great. until somebody picks this up, i wouldn't hold my breath. you're welcome to contribute and then you'll know exactly the schedule!hugomassing commentedon Sep 5, 2019
Any update on this?
EscoCreeks commentedon Jan 10, 2020
Hello, I have deep dived on the issue, and I think we have to upgrade this library to check props from propTypes instead of genDoc, which is (even when having the plugin at the right place) not working.
I've found that addon-info is working like a charm with the PropTable, correctly displaying each props with their type. In its code it can either fetch this data from genDoc or directly from the propTypes.
I'll try to push a PR this week-end to fix this if people are still interested.