Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

Fix select knob. Hide empty option if required. - #66

Closed
RoyalHunt wants to merge 2 commits into
storybook-eol:masterfrom
RoyalHunt:fix-select
Closed

RoyalHunt wants to merge 2 commits into
storybook-eol:masterfrom
RoyalHunt:fix-select

Conversation

@RoyalHunt

Copy link
Copy Markdown

Similar to #60

Difference is in covering flow definitions. propType.required is always false for flow.

@vercel
vercel Bot requested a deployment to staging October 19, 2019 10:35 Abandoned
@vercel

vercel Bot commented Oct 19, 2019

Copy link
Copy Markdown

Deployment failed with the following error:

Your `package.json` file is missing a `build` property inside the `script` property.

@nekitk

nekitk commented Oct 24, 2019

Copy link
Copy Markdown
Contributor

@RoyalHunt I checked in SmartKnobedComponentWithFlow.js example and required field is set correctly for flow. Here's an output for SmartKnobedComponent.__docgenInfo.props[prop] for each prop in the example:

@ndelangen

Copy link
Copy Markdown
Contributor

Could you resolve conflicts and merge in the base branch?

@RoyalHunt

Copy link
Copy Markdown
Author

Looks like master branch already have needed changes for correct work. I'm closing the PR. Thank you!

@RoyalHunt RoyalHunt closed this Apr 7, 2020

This branch had an error being deployed

1 abandoned deployment
staging — 528e08cc Deployed Oct 19, 2019 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants