Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

chore(docs): Add CSF examples - #70

Open
benmvp wants to merge 4 commits into
storybook-eol:masterfrom
benmvp:docs
Open

benmvp wants to merge 4 commits into
storybook-eol:masterfrom
benmvp:docs

Conversation

@benmvp

@benmvp benmvp commented Jan 11, 2020

Copy link
Copy Markdown

Problem

I had two problems:

  1. I was unsure if I had to install @storybook/addon-knobs with storybook-addon-smart-knobs
  2. The examples were not in Component Story Format so I wasn't sure what the equivalent CSF code looked like. Once I did, I was also unsure what order the decorators should go in.

Solution

I updated the installation instructions to include @storybook/addon-knobs for extra clarity.

The main part was adding examples for CSF. I have some set of stories that display the component multiple times in a story, so including the decorator globally messed up those stories because it was passing the same parameters into all of the components. So I added an example of adding the decorator at the story level.

Notes

I also added a fix for what I believe was a bug in the ignoreProps options example.

@vercel

This comment has been minimized.

@vercel
vercel Bot requested a deployment to Preview January 11, 2020 00:00 Abandoned
@vercel

This comment has been minimized.

@vercel
vercel Bot requested a deployment to Preview January 15, 2020 23:22 Abandoned
@vercel

This comment has been minimized.

This branch had an error being deployed

1 abandoned (outdated) deployment
Preview — 9917820b Deployed Jan 15, 2020 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants