fix(release): repair the 5.1.0 changelog, PR body and draft notes - #220
Merged
Conversation
The consolidation put a blank line between the stable entries and the folded-in prerelease entries. A blank line inside a markdown list ends it, so every section in the 5.1.0 release PR rendered as two separate lists with a gap down the middle. The separator is removed and both runs of entries are filtered of blank lines before being joined, so a section is one list. I claimed the previous change was verified. It was not: I checked entry counts, heading order and the maximum run of consecutive blank lines, none of which can see a single blank line sitting between two list items. The check that finds it is looking for exactly that, and it now runs against the output: no blank line between consecutive entries anywhere in the 5.1.0 section. The one remaining split is in the 2022 4.0.0-alpha.0 section, is present in the input, and is left alone. Co-Authored-By: Claude <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#219 broke the changelog in #217. Every section renders as two lists with a gap
down the middle:
The consolidation joined the two runs of entries with a separator:
A blank line inside a markdown list ends it. Removed, and both runs are stripped
of blank lines before joining.
I said that change was verified. It wasn't.
I checked entry counts (36 = 3 + 33), heading order, and the maximum run of
consecutive blank lines. None of those can see a single blank line between two
list items — the count is right, the order is right, and the run length is 1.
The check that finds it looks for exactly that shape, and now runs against the
output:
Zero new splits; the 5.1.0 section is one contiguous list per subsection:
The already-broken branch
release-please regenerates
CHANGELOG.mdon the release branch frommainoneach run, so once this lands the next run rebuilds it and the fixed fold applies.
I will confirm that on #217 rather than assume it — and if the branch does not
regenerate, deleting it makes release-please recreate it cleanly.
🤖 Generated with Claude Code