Repository navigation
Fix new projects whose name contains spaces (#3356) - #3406
Merged
Merged
Conversation
The template engine used the raw name for file names but its safe form for file contents, so The Quiet Archive.Game.csproj was referenced as The_Quiet_Archive.Game.csproj. Both now use a compact form of the name with whitespace removed (TheQuietArchive). Game Studio saves its own solution, named from the New Project dialog, so it now asks the template not to emit one (skipSolution) instead of leaving a second solution behind when the names differ.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
With a project name containing spaces, the template engine renamed files with the raw name
(The Quiet Archive.Game.csproj) but substituted its safe form in file contents
(The_Quiet_Archive.Game.csproj), so the solution, the exec project and the sdpkg path pointed
at files that did not exist.
an underscore, then the engine's identifier cleanup. "The Quiet Archive" -> TheQuietArchive,
"Game 1.5" -> Game1_5, "2D Game" -> _2DGame. The root directory keeps the raw name.
hidden skipSolution parameter instead of leaving the template's solution behind when the
names differ.
Verified with dotnet new, stride new, and a build of the generated project. The Game Studio
dialog itself was not exercised interactively.
Related Issue
Fixes #3356