Repository navigation
Fix SDSL postfix parser silently dropping a dangling '.' or '[' - #3426
Merged
Merged
Conversation
PostfixParser consumed the '.' or '[' and then fell out of the loop when no member, call, index or closing bracket followed, so `a.;`, `1..;` or `a[1;` parsed without error. Report SDSL0021/SDSL0015/SDSL0019 at that point instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
The SDSL postfix parser consumed a '.' or '[' and then silently dropped it when nothing valid followed, so statements like
a.;,1..;ora[1;parsed without any error.This reports a parse error at that point instead (SDSL0021 for a dangling '.', SDSL0015 for '[' without an expression, SDSL0019 for a missing ']'), and adds negative and positive parsing tests for accessor chains.
Follow-up to #3421, which made
1..reachable through this path.Types of changes
Checklist