[ds5678]

PR Details

This pull request replaces uses of BlittableHelper with RuntimeHelpers.IsReferenceOrContainsReferences in animation classes.

Related Issue

BlittableHelper is very inefficient. It has a global lock on every call and uses exception handling to check blittability.

Types of changes

• Docs change / refactoring / dependency upgrade

Checklist

• All new and existing tests passed.
• I have built and run the editor to try this change out.

Context

I'm working on the assembly processor, and this is a change I can separate out for easier review.

The other uses of BlittableHelper are all in the Stride.Updater namespace. Those uses will be removed as part of my work on those classes.

[xen2]

Another idea, what about adding this to AnimationClip?

internal bool IsChannelBlittable(in Channel channel)
{
    if (channel.CurveIndex != -1)
        return Curves[channel.CurveIndex].IsElementBlittable;

    // Optimized channels are grouped by element type (see Optimize)
    if (OptimizedAnimationDatas != null)
    {
        foreach (var optimizedData in OptimizedAnimationDatas)
        {
            if (optimizedData.ElementType == channel.ElementType)
                return optimizedData.IsElementBlittable;
        }
    }

    throw new InvalidOperationException($"Channel [{channel.PropertyName}] has no curve and no optimized data");
}

Note: Just an idea. if not going that way, current approach would work too but invalidate build cache (cf comment)

[xen2]

LGTM otherwise, thanks!