Repository navigation
Game Studio: remove WPF binding errors and Freezable warnings, fix a few editor bugs - #3485
Merged
Merged
Conversation
WindowChrome binds its sizing properties to system parameters, so it can never be frozen: UnfreezableWindowChrome skips the attempt and its warning. The AvalonDock document floating window chrome now sets all of them, like its sibling styles, so it can be frozen. Theme styles use theme brushes instead of brushes built from DynamicResource colors. Remove the unused window button bitmaps.
- The property grid expander arrow no longer looks for a TreeViewItem. - Menu items use fixed content alignments instead of binding them to the parent ItemsControl, which fails for menu items created before they are in a menu.
- Asset-only badges are in an asset template, so folder tiles no longer bind them. - Renaming follows IsEditable: folders in a read-only package can no longer be renamed. - The content no longer inherits the host's DataContext before AssetCollection is set. - AssetContextMenu is typed as a ContextMenu. - Toolbar icon menus no longer bind the icon size to its bitmap pixel size. - Remove a debug Console.WriteLine.
- Pane titles bind the dirty marker only for asset editors, and the tab highlight only inside tabs. - Tool panels set their DataContext, so AvalonDock re-parenting does not give them the layout item.
xen2
force-pushed
the
fix/assetview-binding-errors
branch
2 times, most recently
from
September 25, 2026 19:26
8589072 to
6d50d06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR details
Removes most of the WPF binding errors and Freezable warnings that Game Studio logged in the debugger output (asset view, pane titles, tool panels, property grid, menus, themes, scene and script editors). Binding messages are now printed once instead of twice.
It also fixes a few editor bugs found along the way: