Fix flakey testTelemetryEnabled test - #2250
Merged
Merged
Conversation
jar-stripe
marked this pull request as draft
July 16, 2026 19:37
jar-stripe
changed the title
jar-stripe
marked this pull request as ready for review
July 16, 2026 21:35
jar-stripe
enabled auto-merge (squash)
July 16, 2026 21:35
jar-stripe
disabled auto-merge
July 16, 2026 21:35
jar-stripe
enabled auto-merge (squash)
July 16, 2026 21:35
Contributor
Author
thanks! we'll see if this was entirely the issue 🤞 |
jar-stripe
added a commit
that referenced
this pull request
Jul 16, 2026
* added message to flakey assertion to help us troubleshoot * changed operator from greater than to greater than or equal to
jar-stripe
added a commit
that referenced
this pull request
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The
testTelemetryEnabledtest will fail frequently which can delay releases and other PR merges. This has happened more frequently in the past several months. The condition that is failing tests that the request timeout ms is strictly greater than the 30ms body delay configured in the test. After adding an assertion message that prints out the actual value, it looks like the mock request is completing in 30msI suspect this is a rounding/truncating issue, but either way we should accept any number equal or greater to the delay here.
What?
See Also