Fix the declaration of BASE_IMAGE build argument - #8
Merged
pcarruscag merged 1 commit intoJul 2, 2022
Conversation
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Member
Author
|
Hi @pcarruscag, It seems the Windows build needs manual steps: https://github.com/su2code/Docker-Builds/tree/master/build_cross#preparing-and-creating-msmpi-package I won't be able to work on it next week though. I hope the broken release management work flow does not cause you problems! |
Member
Author
|
I am going to get the Windows binary from the old Docker image and put it in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #7