Skip to content

Run the unsteady NACA0012 tutorial for 20 timesteps - #1616

Merged
pcarruscag merged 4 commits into
developfrom
improve_unsteady_tutorials
May 10, 2022
Merged

Run the unsteady NACA0012 tutorial for 20 timesteps#1616
pcarruscag merged 4 commits into
developfrom
improve_unsteady_tutorials

Conversation

@pcarruscag

@pcarruscag pcarruscag commented Apr 23, 2022

Copy link
Copy Markdown
Member

Starts to address #1604
The adjoint will be more work.
Depends on su2code/Tutorials#22

@lgtm-com

lgtm-com Bot commented Apr 23, 2022

Copy link
Copy Markdown

This pull request fixes 3 alerts when merging cd5c18f into f4f6298 - view on LGTM.com

fixed alerts:

  • 3 for Comparison of narrow type with wide type in loop condition

Comment thread TestCases/tutorials.py Outdated
@lgtm-com

lgtm-com Bot commented Apr 23, 2022

Copy link
Copy Markdown

This pull request fixes 3 alerts when merging 5674c23 into f4f6298 - view on LGTM.com

fixed alerts:

  • 3 for Comparison of narrow type with wide type in loop condition

@TobiKattmann TobiKattmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this Tutorial work nicely again and the additional cleanup on the output stuff 💐 Everything lgtm so feel free to merge this and the Tutorial PR from my side

Comment thread .github/workflows/regression.yml Outdated
@pcarruscag
pcarruscag merged commit fa910a0 into develop May 10, 2022
@pcarruscag
pcarruscag deleted the improve_unsteady_tutorials branch May 10, 2022 01:24
@lgtm-com

lgtm-com Bot commented May 10, 2022

Copy link
Copy Markdown

This pull request fixes 3 alerts when merging 3fa0e2a into 6acc62f - view on LGTM.com

fixed alerts:

  • 3 for Comparison of narrow type with wide type in loop condition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants