Bugfix for a call to LoadUnsteady_Solution in CDiscAdjFluidIteration::Preprocess - #1638
Merged
pcarruscag merged 2 commits intoMay 19, 2022
Merged
Conversation
…:Preprocess. The arguments of iZone and iInst were swapped.
pcarruscag
approved these changes
May 18, 2022
pcarruscag
left a comment
pcarruscag
left a comment
Member
There was a problem hiding this comment.
Thanks Max, seems that we have that mistake also in lines 150 and 152, can you update them please?
Contributor
Author
|
Sure, actually I looked at other places but have missed these. |
TobiKattmann
approved these changes
May 18, 2022
TobiKattmann
left a comment
TobiKattmann
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this fix Max 💐
WallyMaier
approved these changes
May 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameters in iInst and iZone are swapped which gives a segmentation fault for adjoint HB computations.