Skip to content

Remove legacy build system - #1961

Merged
pcarruscag merged 4 commits into
developfrom
remove_legacy_build
Mar 19, 2023
Merged

Remove legacy build system#1961
pcarruscag merged 4 commits into
developfrom
remove_legacy_build

Conversation

@pcarruscag

Copy link
Copy Markdown
Member

Proposed Changes

Remove the legacy build files as mentioned in the plan for SU2 v8 #1925

@pcarruscag pcarruscag left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 145k lines is because we had a .vtk file committed somewhere in the repo 🤷

@bigfooted

Copy link
Copy Markdown
Contributor

It's just removing a bunch of files? Then LGTM

@bigfooted bigfooted left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@WallyMaier WallyMaier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@jtneedels jtneedels left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pcarruscag
pcarruscag merged commit ccf1b17 into develop Mar 19, 2023
@pcarruscag
pcarruscag deleted the remove_legacy_build branch March 19, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants