Feature new flamelet: addition of preferential diffusion - #2156
Merged
Conversation
…t solution ignition
…into feature_new_flamelet
…low problems without isothermal walls
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
NAnand-TUD
reviewed
Nov 6, 2023
bigfooted
reviewed
Nov 6, 2023
bigfooted
reviewed
Nov 6, 2023
bigfooted
reviewed
Nov 6, 2023
…GetEnthFromTemp convergence settings in accordance with develop
EvertBunschoten
marked this pull request as ready for review
April 17, 2024 14:47
EvertBunschoten
changed the title
…into feature_new_flamelet
bigfooted
reviewed
Apr 24, 2024
pcarruscag
approved these changes
Apr 25, 2024
bigfooted
reviewed
Apr 26, 2024
bigfooted
reviewed
Apr 26, 2024
bigfooted
reviewed
Apr 26, 2024
| } | ||
|
|
||
| bool CLookUpTable::CheckForVariables(const std::vector<std::string>& vars_to_check) const { | ||
| for (const string& var_to_check : vars_to_check) { |
Check notice
Code scanning / CodeQL
Unused local variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Addition of preferential diffusion model for modeling of hydrogen-rich reactants.
The new features allow for an additional transported scalar; the mixture fraction. This enables the solution process for partially pre-mixed, laminar flame problems, as well as the implementation of preferential diffusion.
A detailed description of the SU2 FGM solver can be found on the SU2 website repository (https://github.com/su2code/su2code.github.io) under feature_new_flamelet.
Related Work
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.