Fix bugs detected by the address sanitizer - #2212
Merged
Merged
Conversation
added 6 commits
February 14, 2024 14:16
In CPhysicalGeometry.cpp, instances of derived classes are delete'd via CMeshReaderFVM pointers. Without a virtual destructor, destructors of members added by these derived classes are not called. With respect to e.g. the std::vector members of CCGNSMeshReaderFVM, this leads to memory leaks.
pcarruscag
approved these changes
Feb 14, 2024
pcarruscag
reviewed
Feb 14, 2024
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
This helps to avoid memory leaks and double frees from the respective COptionActDisk instances, and allows to check that identical marker lists were supplied.
to fix memory leak.
…nto fix_addresssanitizer_findings
pcarruscag
approved these changes
Feb 16, 2024
Contributor
|
The contributions I made are from investigating |
jblueh
marked this pull request as ready for review
February 17, 2024 01:27
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce the underlying issue
Compile SU2 with Clang and
-fsanitize=address(and possibly-fno-omit-frame-pointer), and run the testcases as usual. AddressSanitizer warnings appear in the output (if any).So far, only the tests in serial_regression.py have been analyzed.
Proposed Changes
Depending on the context of the memory leak,
delete/delete[]statementnew-allocated arrays intostd::vectors, ordeleteto a base class pointer, make its destructorvirtual.Related Work
#2211 and #2213 have been detected in the same way, but I'm not sure how to properly fix them.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.