Skip to content

Update regression tests for tutorials - #2423

Merged
pcarruscag merged 25 commits into
developfrom
tutorial_bend_Design
Feb 2, 2025
Merged

Update regression tests for tutorials#2423
pcarruscag merged 25 commits into
developfrom
tutorial_bend_Design

Conversation

@bigfooted

@bigfooted bigfooted commented Jan 15, 2025

Copy link
Copy Markdown
Contributor

Proposed Changes

Add regression test for 90 degree bend adjoint design tutorial

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Comment thread TestCases/tutorials.py Fixed

@pcarruscag pcarruscag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I meant by testing one iteration was to test the entire optimization script by doing one iteration, not just test each call to SU2.
I guess we need to add FADO to the SU2 installation?

Comment thread TestCases/tutorials.py Outdated
Comment thread TestCases/tutorials.py
@bigfooted

Copy link
Copy Markdown
Contributor Author

What I meant by testing one iteration was to test the entire optimization script by doing one iteration, not just test each call to SU2. I guess we need to add FADO to the SU2 installation?

Yes, I am using FADO. Can you help in making FADO available during regression testing?

@pcarruscag

Copy link
Copy Markdown
Member

I'll try to do it tonight.

@pcarruscag

Copy link
Copy Markdown
Member

It's done, I have to update the init.py script but I'll do that after I check that the FADO examples work with the current version of SU2.

Comment thread TestCases/tutorials.py Outdated
Comment thread docker/test/runTests.sh Outdated
Comment thread TestCases/tutorials.py Outdated
@pcarruscag pcarruscag changed the title [WIP] Update regression tests for tutorials Update regression tests for tutorials Feb 1, 2025
Comment thread .github/workflows/regression.yml Outdated
@pcarruscag
pcarruscag merged commit 57667b2 into develop Feb 2, 2025
@pcarruscag
pcarruscag deleted the tutorial_bend_Design branch February 2, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants