Skip to content

Fix #2464: Removed restart check from spark initiation - #2487

Merged
EvertBunschoten merged 1 commit into
developfrom
2464-fix_flame_init
Apr 10, 2025
Merged

Fix #2464: Removed restart check from spark initiation#2487
EvertBunschoten merged 1 commit into
developfrom
2464-fix_flame_init

Conversation

@EvertBunschoten

@EvertBunschoten EvertBunschoten commented Apr 9, 2025

Copy link
Copy Markdown
Member

Proposed Changes

The spark initiation method for the flamelet solver was automatically disabled for restarts. Now it's enabled.

Related Work

Fix for issue #2464

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@bigfooted

Copy link
Copy Markdown
Contributor

Do we give a clear message when starting, that ignition is activated? Or maybe at the moment/iteration nr that we ignite we can give a message that we ignite. Just to make it clearly visible to the user.

@EvertBunschoten

Copy link
Copy Markdown
Member Author

Do we give a clear message when starting, that ignition is activated? Or maybe at the moment/iteration nr that we ignite we can give a message that we ignite. Just to make it clearly visible to the user.

Right before starting the solver, a message is displayed saying that the solution is initiated with an artificial spark. It doesn't currently give a message when ignition takes place.

@bigfooted bigfooted left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Evert!

@EvertBunschoten
EvertBunschoten merged commit b5f6ac3 into develop Apr 10, 2025
@EvertBunschoten
EvertBunschoten deleted the 2464-fix_flame_init branch April 10, 2025 14:01
raghava-davuluri pushed a commit to hypersonic-lab/SU2 that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FLAME_INIT_METHOD= SPARK is always deactivated when restarting

2 participants