Repository navigation
Remove S3/MinIO config for screenshot service - #173
Merged
Merged
Conversation
No longer needed (screenshot is always returned in this context)
cameron-dunn-sublime
force-pushed
the
cd.remove-screenshots-s3-config
branch
from
August 6, 2024 16:10
4eb0dc6 to
9dac98d
Compare
cameron-dunn-sublime
marked this pull request as ready for review
August 6, 2024 23:19
rw-access
approved these changes
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longer needed (the screenshot is always returned in this context). Removing these env vars would be compatibly with all recent
0.1versions ofsublimesec/render-email-html, but I'm following standard procedure and bumping to0.2to prevent any issues for anyone with very stale versions ofsublimesec/render-email-html.