Repository navigation
Prefix container names with sublime_ - #70
Conversation
| image: sublimesec/bora-lite:0.39 | ||
| restart: unless-stopped | ||
| container_name: bora-lite | ||
| container_name: sublime_bora-lite |
There was a problem hiding this comment.
while we're at it... any objections to using underscores for everything for consistency?
There was a problem hiding this comment.
Just went ahead and added sublime_ to everything basically for consistency including the service names.
| - AWS_REGION=us-east-1 | ||
| - DISABLE_DD=true | ||
| container_name: screenshot-service | ||
| container_name: sublime_screenshot-service |
cameron-dunn-sublime
left a comment
cameron-dunn-sublime
left a comment
There was a problem hiding this comment.
Should we rename sublimes3 to sublime_s3 as well?
| minio server --address 0.0.0.0:8110 --console-address 0.0.0.0:8111 /data; | ||
| " | ||
| create-buckets: | ||
| sublime_create_buckets: |
There was a problem hiding this comment.
@cameron-dunn-sublime this was the only container with something that kind of resembled an error:
2023-01-24 14:38:45 mc: <ERROR> Unable to initialize new alias from the provided credentials. Invalid Request (invalid hostname).
2023-01-24 14:38:45 Bucket created successfully `myminio/email-screenshots`.
2023-01-24 14:38:45 [2023-01-24 22:38:45 UTC] 4.0KiB email-screenshots/
Is this expected or do I need to update something here?
| - create-buckets | ||
| - sublime_create_buckets | ||
| # Keep this name as sublimes3 because underscores don't play nice with certain endpoint validation | ||
| sublimes3: |
There was a problem hiding this comment.
@cameron-dunn-sublime helped me verify that using an underscore here causes an invalid host name. We verified everything else!
| distribution: 600 | ||
| scanner: 150 | ||
| coordinator: | ||
| addr: 'strelka_coordinator_1:6379' |
There was a problem hiding this comment.
does this underscore have issues too? should we use dashes?
There was a problem hiding this comment.
I checked the Strelka backend container logs and it looks like it finds the coordinator:
2023-01-24 15:35:52 2023-01-24 23:35:52 - [INFO] root [strelka-backend.main]: using backend configuration /etc/strelka/backend.yaml
2023-01-24 15:35:52 2023-01-24 23:35:52 - [DEBUG] root [strelka-backend.main]: verified coordinator is up
4 participants
There may be collisions with existing Docker containers (e.g.
postgres) so this prefixes all Docker containers withsublime_.Tested locally with
clone_platform=false ./install-and-launch.sh