ποΈ(deps) upgrade dependencies with known vulnerabilities - #100
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: β Files ignored due to path filters (3)
π Files selected for processing (3)
π WalkthroughWalkthroughThe pull request upgrades three server dependencies, adds a client override for ChangesDependency security updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other β¨ Finishing Touches π‘ 1π οΈ Fix failing CI checks π‘
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Upgrade dependencies with known vulnerabilities, in one PR instead of the ~30 overlapping Snyk/Renovate PRs (which conflict on the same lockfiles).
Server
bcrypt5 β 6: drops@mapbox/node-pre-gypand its vulnerabletar(critical). API unchanged; existing$2b$hashes still verify (checked against a hash produced by bcrypt 5.1.1).nodemailer6 β 10: only breaking change is Node β₯ 20 (we run 22). We only usecreateTransport.sharp0.33 β 0.35: libvips CVEs on image processing (attachments, avatars, backgrounds). None of the 0.34/0.35 breaking changes touch our calls (metadata,rotate,resize,toBuffer).npm audit fix(in-range): express, socket.io, ws, lodash, validator, sails, sails-hook-sockets, @aws-sdk/client-s3β¦Client
npm audit fix(in-range): axios, js-cookie, lodash, nanoid, react-router-dom 6.30.6β¦js-yamlforced to^4.3.2under@mdxeditor/editorviaoverrides(mdxeditor 3.x pins 4.1.1). Avoids the risky mdxeditor 3 β 4 major bump proposed by Snyk.Remaining, not fixed on purpose
react-router(moderate): fix only in v7. Not exploitable here: no navigation to user-controlled paths, no SSR.socket.io-client2.5 /parseuri(moderate): only parses our own socket URL; v4 needs a sails.io compatibility check.uuid(moderate): only affects v3/v5/v6 with abufargument; we only usev4.body-parser/qsviasails(moderate): no fix available in sails 1.x.react-scripts,@cucumber/cucumber,mochachains: build/test tooling, not shipped.Pull-Request Checklist
mainbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000: N/A, supersedes bot PRs listed aboveSummary by CodeRabbit