Skip to content

Fold the temperature response in the wavelength unit of the spectra - #232

Draft
nabobalis wants to merge 1 commit into
sunpy:mainfrom
nabobalis:spectra-wavelength-unit
Draft

nabobalis wants to merge 1 commit into
sunpy:mainfrom
nabobalis:spectra-wavelength-unit

Conversation

@nabobalis

Copy link
Copy Markdown
Member

Summary

 SourceSpectra.temperature_response(channel)
-  channel wavelengths in Angstrom, compared with spectra wavelengths in their own unit
+  channel wavelengths converted to the spectra's wavelength unit

Spectra in any unit other than Angstrom gave a zero response.

Evidence

Merge Danger

Door: two-way

Blast Radius: values, only for spectra not in Angstrom (they were zero).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant