fix: GetGitRoot stuck#54
Merged
Merged
Conversation
|
🎉 This PR is included in version 0.10.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
dumko2001
pushed a commit
to dumko2001/cli
that referenced
this pull request
Mar 15, 2026
kallebysantos
pushed a commit
to kallebysantos/supabase-cli
that referenced
this pull request
May 6, 2026
## What kind of change does this PR introduce?
This adds e2e test coverage for four `domains` commands and the option
to run parity tests with handwritten fixtures.
We can't really test the `domains` commands against staging, since we'd
have to set up actual DNS records to verify the happy path — so we're
using handwritten fixtures (recorded with Proxyman) for the happy path
and recorded responses for the unhappy path ("custom domain not
enabled").
I encountered two blockers here:
- The parity checks should probably test `domains get`, which is
scenario based – that's why I added scenario support to `testParity`
- The `domains create` commands first verify CNAME records by querying
`1.1.1.1`. IIUC, we can only mock that at the OS level, since it's
hard-coded in the Go binary — should we skip the test?
## What is the current behavior?
There was no e2e coverage for the domains commands.
Fixes CLI-1380
## What is the new behavior?
- testParity now supports scenarios
- `domains get` has behavior and parity tests for `--output json`
- `domains get` has coverage for various error paths (400, 401, 403,
429, 500, 502)
- e2e tests for `domains` commands based on various states:
- Custom Domains not enabled
- Custom Domains enabled, but no Custom Domain set
- Custom Domain set, but verification pending
- Custom Domain set & verified, but not activated
- Custom Domain activated
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53.