Skip to content

fix(memory-graph): distinguish document links from derives relations - #1701

Merged
graphite-app[bot] merged 1 commit into
mainfrom
capy/distinguish-document-links-from
Sep 25, 2026
Merged

graphite-app[bot] merged 1 commit into
mainfrom
capy/distinguish-document-links-from

Conversation

@sohamd22

Copy link
Copy Markdown
Contributor

Document-to-memory links and actual derives relations were both emitted as derives, so they shared the same color and legend entry.

This separates structural document links into a document edge type, adds a dedicated theme color with --graph-edge-document support, and updates force-layout and level-of-detail handling to preserve existing structural behavior. The package and MCP widget legends/themes now distinguish document links from derived-memory relations.

Adds regression coverage for edge classification and validates the package plus its MCP consumer.

Open in Capy

@polylane

polylane Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Note

Production impact unlikely.

Checked the edge-type rename and the new required edgeDocument theme key against supermemory-mcp, the only production consumer of packages/memory-graph: the edge string is produced and read inside the same bundle, and the Worker served 1.81M requests over 64h with zero invocation errors.

View the full analysis →

Also considered · 3 refuted
  • Refuted · Widget reads a pre-rename derives edgeType from a serialized graph · No edge object crosses a process or version boundary.
  • Refuted · New required edgeDocument key breaks a consumer's build or runtime theme · packages/memory-graph/src/types.ts:118 adds edgeDocument: string (required), but every in-repo consumer is updated in the same diff and none builds a complete literal: apps/mcp/src/widget/views/Graph.tsx declares GRAPH_VARS with satisfies Record<Exclude<keyof GraphThemeColors, "dotColor">, string> and adds edgeDocument: "--graph-edge-document", DEFAULT_COLORS and resolveColors (use-graph-theme.ts) both supply it, and apps/memory-graph-playground/src/app/page.tsx:75 uses satisfies Partial<GraphThemeColors>.
  • Refuted · Legend loses label overrides for the document and derives rows · The new legend row does hardcode English text — packages/memory-graph/src/components/legend.tsx:545 <span style={edgeLabelStyle}>Derives</span> and line 555 Memory derived from another memory — while every neighbouring row reads from labels.*, so a host override for a derives label would no longer apply.

supermemory-mcp · requests per hour

supermemory-mcp · errors per hour

Analysed against 2 Cloudflare Workers and 1 repository

View in Polylane Disable reviews

Polylane analysed cfa6c7c for production impact. You can ask follow-ups by mentioning @polylane in a comment.

Rate this review: 👍 helpful · 👎 not helpful · 😕 confusing

Previous verdicts (1)
Head Verdict Analysis
0fd4fa0 Production impact unlikely analysis

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
🔵 In progress
View logs
supermemory-mcp cfa6c7c Sep 25 2026, 10:00 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
🔵 In progress
View logs
supermemory-app cfa6c7c Sep 25 2026, 10:00 PM

@graphite-app

graphite-app Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Merge activity

…1701)

Document-to-memory links and actual `derives` relations were both emitted as `derives`, so they shared the same color and legend entry.

This separates structural document links into a `document` edge type, adds a dedicated theme color with `--graph-edge-document` support, and updates force-layout and level-of-detail handling to preserve existing structural behavior. The package and MCP widget legends/themes now distinguish document links from derived-memory relations.

Adds regression coverage for edge classification and validates the package plus its MCP consumer.

<!-- capy-badge:start -->
<a href="https://capy.ai/thread/jam_01M36F4MPFXZCA8J14T53YY029"><picture><source media="(prefers-color-scheme: dark)" srcset="https://capy.ai/badge/accent-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://capy.ai/badge/accent-light.svg"><img alt="Open in Capy" src="https://capy.ai/badge/accent-light.svg"></picture></a>
<!-- capy-badge:end -->
@graphite-app
graphite-app Bot force-pushed the capy/distinguish-document-links-from branch from 0fd4fa0 to cfa6c7c Compare September 25, 2026 22:00
@graphite-app
graphite-app Bot merged commit cfa6c7c into main Sep 25, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants