Skip to content

feat: welcome ai-tools#1050

Open
jycouet wants to merge 13 commits into
mainfrom
ai-tools
Open

feat: welcome ai-tools#1050
jycouet wants to merge 13 commits into
mainfrom
ai-tools

Conversation

@jycouet
Copy link
Copy Markdown
Contributor

@jycouet jycouet commented Apr 6, 2026

Closes #1044

Description

replace mcp add-on with ai-tools add-on that includes both MCP and skills setup

Checklist

  • Update snapshots (if applicable)
  • Add a changeset (if applicable)
  • Allow maintainers to edit this PR
  • I care about what I'm doing, no matter the tool I use (Notepad, Sublime, VSCode, AI...)

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 6, 2026

🦋 Changeset detected

Latest commit: e7d1d77

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link
Copy Markdown

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 6, 2026

Open in StackBlitz

npx https://pkg.pr.new/svelte-migrate@1050
npx https://pkg.pr.new/sv@1050
npx https://pkg.pr.new/@sveltejs/sv-utils@1050

commit: e7d1d77

@jycouet
Copy link
Copy Markdown
Contributor Author

jycouet commented Apr 6, 2026

@paoloricciuti I added skills for opencode & claude, but not for others. I know that cursor is looking at skills as well (maybe even in .claude/skills). Could you advise?

Comment thread documentation/docs/30-add-ons/01-ai-tools.md
Comment thread packages/sv/src/addons/ai-tools.ts Outdated
Comment thread packages/sv/src/addons/ai-tools.ts
@paoloricciuti
Copy link
Copy Markdown
Member

@jycouet I think almost every tool nowadays looks at skills, you can check the right folder with the skills.sh cli

@paoloricciuti
Copy link
Copy Markdown
Member

I wonder if we should just invoke that actually 🤔

@jycouet
Copy link
Copy Markdown
Contributor Author

jycouet commented Apr 6, 2026

@jycouet I think almost every tool nowadays looks at skills, you can check the right folder with the skills.sh cli

Since it's solving only skills and not mcp / agent / sub-agent, ... I'm not sure we should rely on this. But I'm maybe wrong

@jycouet
Copy link
Copy Markdown
Contributor Author

jycouet commented May 7, 2026

I wonder if we should just invoke that actually 🤔

We leave it like that for now? :D

Comment on lines +227 to +242
const claudeSkillsDir = path.resolve(cwd, '.claude/skills');
expect(fs.existsSync(claudeSkillsDir)).toBe(true);
expect(fs.existsSync(path.resolve(claudeSkillsDir, 'svelte-code-writer/SKILL.md'))).toBe(true);
expect(fs.existsSync(path.resolve(claudeSkillsDir, 'svelte-core-bestpractices/SKILL.md'))).toBe(
true
);

// opencode should NOT have skills (plugin handles it)
expect(fs.existsSync(path.resolve(cwd, '.opencode/skills'))).toBe(false);

// sub-agents should be installed for all clients except opencode
expect(fs.existsSync(path.resolve(cwd, '.claude/agents/svelte-file-editor.md'))).toBe(true);
expect(fs.existsSync(path.resolve(cwd, '.cursor/agents/svelte-file-editor.md'))).toBe(true);
expect(fs.existsSync(path.resolve(cwd, '.gemini/agents/svelte-file-editor.md'))).toBe(true);
expect(fs.existsSync(path.resolve(cwd, '.github/agents/svelte-file-editor.agent.md'))).toBe(true);
expect(fs.existsSync(path.resolve(cwd, '.opencode/agents'))).toBe(false);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, we also suggest claude code (and cursor) users to use the plugin but I don't think there's a way to programmatically add a plugin to claude code (and cursor). What I'm worried about is if we install the skills/subagents, and then they add the plugin (and they have multiple skills/subagents)

Comment on lines +32 to +45
.add('skills', {
question: 'Do you want to install skills?',
type: 'select',
default: 'files',
options: [
{ value: 'files', label: 'Add files to the project' },
{
value: 'none',
label: 'Skip',
hint: 'for Claude Code you can install the plugin instead: /plugin install svelte'
}
],
condition: ({ ide }) => ide.some((i) => i !== 'opencode' && i !== 'other')
})
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add a skill selection? Right now, there's only two, but maybe in the future there will be more, and you don't want them all?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this fail if we add more skills in the repo?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this, we don't check content update, but yes we need to update the snapshot when we have new skills / ref / ...
I find this as a good balance.

Multiple options:

  • A/ Skip completely
  • B/ snapshot the full content
  • C/ Keep like this

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we setup a github action that invokes this whenever skills changes in the ai-tools repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skills add-on

2 participants