Skip to content

feat: rename --check-types to --[no-]types#249

Merged
manuel3108 merged 6 commits into
mainfrom
feat/simplify-types-flag
Oct 29, 2024
Merged

feat: rename --check-types to --[no-]types#249
manuel3108 merged 6 commits into
mainfrom
feat/simplify-types-flag

Conversation

@AdrianGonz97
Copy link
Copy Markdown
Member

@AdrianGonz97 AdrianGonz97 commented Oct 29, 2024

closes #239

  • Renamed --check-types <lang> to --[no-]types <lang>
  • Changed <lang> args from: --check-types <typescript|checkjs|none> to: --types <ts|jsdoc> and --no-types
  • Flags will automatically be merged into a single --[no-]{flag} option in the help menu if there exists a --no-{name} and --{name} flag

Here's how the help menu will look for create:

Usage: sv create [options] [path]

scaffolds a new SvelteKit project

Arguments:
  path                 where the project will be created (default: "/home/koala/Tests/svelte-add-testing")

Options:
  --template <type>    template to scaffold (choices: minimal, demo, library)
  --[no-]types <lang>  add type checking (choices: ts, jsdoc)
  --no-integrations    skip interactive integration installer
  --no-install         skip installing dependencies

Also added the changeset as a minor since this is technically breaking

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 29, 2024

🦋 Changeset detected

Latest commit: 63d2a00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Oct 29, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/sv@249

commit: 63d2a00

@manuel3108 manuel3108 merged commit 9ab8328 into main Oct 29, 2024
@manuel3108 manuel3108 deleted the feat/simplify-types-flag branch October 29, 2024 16:39
@github-actions github-actions Bot mentioned this pull request Oct 29, 2024
@Rich-Harris Rich-Harris mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename --check-types to --types, and adjust options?

2 participants