chore: switch to estree compatible ast tooling#380
Merged
Conversation
🦋 Changeset detectedLatest commit: c850286 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This was referenced Dec 31, 2024
Member
Author
|
updated PR description to be more accurate. |
Member
Author
|
We are getting close... 🎉 Tests are finally green. Only thing left is to write some code to properly detect |
estree compatible ast tooling
6 tasks
benmccann
reviewed
Mar 17, 2025
Member
benmccann
left a comment
There was a problem hiding this comment.
I tested it out and the output looks great!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44
Closes #118
Relates #100
This basically duplicates #100 at this point. See #100 for up and downsides of this approach.
I was initially intending to get rid of a lot more dependencies (like the dependencies for handling html) and use
svelte-ast-printinstead, but this was opening too many issues at the same time. That's why I opted to "only" switch toacornandesraphere, the rest can be done later.Relevant PR's / issues
TSModuleDeclarationesrap#44TSImportTypeesrap#47@sveltejs/acorn-typescriptesrap#51Benefits
svelteecosystemrolldown#371)recastesrapDownsides
TSEstreeas no good public alternative exists, that matchesacorns output. We do have@typescript-eslint/typesbut that was just the one with the smallest pain points. Still exploring other options.