fix: package manager detection in non interactive environments#503
Merged
Merged
Conversation
commit: |
Contributor
|
It works! This is how I've tested it: pnpm i https://pkg.pr.new/sveltejs/cli/sv@503 -D// https://github.com/hyunbinseo/svelte-kit-templates/blob/c4dd93a7559e51f2e8196716f44e0b68e69afc98/index.test.js
import { execSync } from 'node:child_process';
execSync('pnpm sv create --template minimal --no-add-ons --types jsdoc javascript');
execSync('pnpm sv add --no-preconditions --cwd javascript eslint prettier');
execSync('pnpm sv create --template minimal --no-add-ons --types ts typescript');
execSync('pnpm sv add --no-preconditions --cwd typescript eslint prettier'); |
Member
Author
|
Great that this works! You could probably just have used |
Merged
Member
Author
|
Will be further enhanced by #531 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #502
p.select(was actually throwing, which caused the formatting relevant source code to be skipped.@hyunbinseo Could you please check if this works for you?
pkg-pr-newurl will be posted in a second.