feat: paraglide adder#67
Conversation
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
commit: |
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 63e065a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
It seems this error message occurs because we're passing -1 as the start (Rich-Harris/magic-string#288) |
|
This is working now! Do you think there's a way to improve the formatting? I'm not sure why it's adding everything on one line and if we can insert some new lines to make it a bit better |
|
Nice! Seems like We could discuss if we should add spaces or tabs, but adding tabs in the code feels way more natural than having to count 4 spaces. The rest should be handled in userland. |
benmccann
left a comment
There was a problem hiding this comment.
shit it! 🚢
nice work on all the improvements here!


Notes:
svelte-add. I tried patching in their changes, which obviously only worked to some degree. But at least git recognizes that they authored those commits nowhooks.tsfilenew features:
placeholders, and can provide avalidatefunction (implemented by @LorisSigrist)preInstall&postInstallhooks. This was necessary because this adder needs to generated multiple files past on astringoption inputtodos:
add teststhey are not yet implemented, we can easily do this later.