Skip to content

chore: change dependencies to devDependencies in addons#682

Merged
manuel3108 merged 2 commits into
mainfrom
chore/depsTodevDeps
Sep 6, 2025
Merged

chore: change dependencies to devDependencies in addons#682
manuel3108 merged 2 commits into
mainfrom
chore/depsTodevDeps

Conversation

@jycouet
Copy link
Copy Markdown
Contributor

@jycouet jycouet commented Aug 31, 2025

Closes: #651

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 31, 2025

🦋 Changeset detected

Latest commit: a0c58fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Aug 31, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@682
npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@682

commit: a0c58fc

Copy link
Copy Markdown
Member

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for not moving @node-rs/argon2 to dev in lucia? Seems to be working for me locally.

Otherwise, this looks perfect.

Comment thread .changeset/fancy-cars-stand.md Outdated
Co-authored-by: Manuel <30698007+manuel3108@users.noreply.github.com>
@jycouet
Copy link
Copy Markdown
Contributor Author

jycouet commented Sep 5, 2025

Any reason for not moving @node-rs/argon2 to dev in lucia? Seems to be working for me locally.

Otherwise, this looks perfect.

I think it's working in development (pnpm dev), but you should not be able to build (pnpm build) if it's in devDependencies therefore it has to stay in dependencies

@manuel3108
Copy link
Copy Markdown
Member

build and preview work for me in this case

@jycouet
Copy link
Copy Markdown
Contributor Author

jycouet commented Sep 5, 2025

Ha, found it!

You need @node-rs/argon2 in dependencies if you have @sveltejs/adapter-node. If not, the build will fail.

Copy link
Copy Markdown
Member

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm!
Thank you!

@manuel3108 manuel3108 merged commit 2287ac1 into main Sep 6, 2025
8 checks passed
@manuel3108 manuel3108 deleted the chore/depsTodevDeps branch September 6, 2025 12:11
@github-actions github-actions Bot mentioned this pull request Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review dependencies vs devDependencies

2 participants