chore: storybook new cli ux#781
Conversation
|
commit: |
Co-authored-by: Jeppe Reinhold <jeppe@reinhold.is>
| '--features', | ||
| 'docs' |
There was a problem hiding this comment.
Should be --no-features in the future according to Jeppe
|
Since this is mainly related to our testing and no user facing code was change, merging without changeset |
| import { defineAddon } from '@sveltejs/cli-core'; | ||
| import { getNodeTypesVersion } from '../common.ts'; | ||
|
|
||
| export const STORYBOOK_VERSION = '10.1.0'; |
There was a problem hiding this comment.
I think this was a mistake, as it now version locks the Storybook version, instead of just getting the latest.
So when you run sv now with Storybook, you get a warning:
should probably revert back to latest.
| `create-storybook@${STORYBOOK_VERSION}`, | ||
| '--skip-install', | ||
| '--no-dev', | ||
| '--no-features' |
There was a problem hiding this comment.
I don't think this should be in production, I think users should be able to choose the feature they want. Storybook will prompt them when this flag is not set.
When we discussed this, I thought you only put in the flag in your tests, to speed them up.
3 participants
Contains minor changes to the way we test the storbook integration. Especially to make CI testing faster.
Currently uses a canary release. DO NOT MERGE.