Skip to content

fix: Cloudflare adapter integrations #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manuel3108 merged 5 commits into from
Dec 30, 2025
Merged

fix: Cloudflare adapter integrations #866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e15d343
Update path for worker-configuration type
teemingc Dec 29, 2025
8f4b2f8
Create honest-tables-compete.md
teemingc Dec 29, 2025
ca1bdec
Update index.ts
teemingc Dec 29, 2025
387cac1
Create smooth-walls-remain.md
teemingc Dec 29, 2025
271ea16
Apply suggestions from code review
manuel3108 Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/honest-tables-compete.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"sv": patch
---

fix(cloudflare): use a relative path for worker-configuration type in the tsconfig.json file
5 changes: 5 additions & 0 deletions .changeset/smooth-walls-remain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"sv": patch
---

fix(cloudflare): local preview is now using port `4173` so that it works with the Playwright test command
6 changes: 3 additions & 3 deletions packages/sv/lib/addons/sveltekit-adapter/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@ export default defineAddon({
// in sk 3, we will keep "preview": "vite preview" like any other adapter
if (options.adapter === 'cloudflare') {
if (options.cfTarget === 'workers') {
data.scripts.preview = 'wrangler dev .svelte-kit/cloudflare/_worker.js';
data.scripts.preview = 'wrangler dev .svelte-kit/cloudflare/_worker.js --port 4173';
} else if (options.cfTarget === 'pages') {
data.scripts.preview = 'wrangler pages dev .svelte-kit/cloudflare';
data.scripts.preview = 'wrangler pages dev .svelte-kit/cloudflare --port 4173';
}
}

Expand Down Expand Up @@ -202,7 +202,7 @@ export default defineAddon({

data.compilerOptions ??= {};
data.compilerOptions.types ??= [];
data.compilerOptions.types.push('worker-configuration.d.ts');
data.compilerOptions.types.push('./worker-configuration.d.ts');

return generateCode();
});
Expand Down
Loading