Skip to content

chore: don't change directory in the basics test setup - #16894

Merged
elliott-with-the-longest-name-on-github merged 1 commit into
version-3from
fix-basics-error-log
Aug 22, 2026
Merged

elliott-with-the-longest-name-on-github merged 1 commit into
version-3from
fix-basics-error-log

Conversation

@Nic-Polumeyv

@Nic-Polumeyv Nic-Polumeyv commented Aug 21, 2026 •

Copy link
Copy Markdown
Member

packages/kit/test/apps/basics/test/setup.js changes directory to src/routes/routing to create the route symlink, then deletes test/errors.jsonl with a path relative to the app root. On non-Windows the chdir happens first, so the delete resolves under src/routes/routing/ and the log written by hooks.server.js is never cleared between runs on Linux and macOS. read_errors in test/utils.js picks the last record matching a path, so a stale record from an earlier run can satisfy an assertion. The rmSync came in with #16664; the chdir block predates it.

Node resolves a symlink's target relative to the link's own directory, so the symlink can be created from the app root. Dropping the chdir keeps every path in the script relative to the same place, so line order can't matter again.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Aug 21, 2026 •

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from beaac33:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/beaac33055ebc581c50172e15ce1b5b530ac204a

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16894

@changeset-bot

changeset-bot Bot commented Aug 21, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: beaac33

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

@Nic-Polumeyv Nic-Polumeyv changed the title chore: clear the basics error log before changing directory chore: don't change directory in the basics test setup Aug 21, 2026
@elliott-with-the-longest-name-on-github
elliott-with-the-longest-name-on-github merged commit 117e789 into version-3 Aug 22, 2026
40 checks passed
@elliott-with-the-longest-name-on-github
elliott-with-the-longest-name-on-github deleted the fix-basics-error-log branch August 22, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants