Repository navigation
chore: don't change directory in the basics test setup - #16894
Merged
elliott-with-the-longest-name-on-github merged 1 commit intoAug 22, 2026
Merged
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/beaac33055ebc581c50172e15ce1b5b530ac204aOpen in |
|
Nic-Polumeyv
force-pushed
the
fix-basics-error-log
branch
from
August 21, 2026 22:41
430bbdd to
beaac33
Compare
elliott-with-the-longest-name-on-github
approved these changes
Aug 22, 2026
elliott-with-the-longest-name-on-github
merged commit Aug 22, 2026
117e789
into
version-3
40 checks passed
elliott-with-the-longest-name-on-github
deleted the
fix-basics-error-log
branch
August 22, 2026 00:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packages/kit/test/apps/basics/test/setup.jschanges directory tosrc/routes/routingto create the route symlink, then deletestest/errors.jsonlwith a path relative to the app root. On non-Windows thechdirhappens first, so the delete resolves undersrc/routes/routing/and the log written byhooks.server.jsis never cleared between runs on Linux and macOS.read_errorsintest/utils.jspicks the last record matching a path, so a stale record from an earlier run can satisfy an assertion. ThermSynccame in with #16664; thechdirblock predates it.Node resolves a symlink's target relative to the link's own directory, so the symlink can be created from the app root. Dropping the
chdirkeeps every path in the script relative to the same place, so line order can't matter again.