Repository navigation
fix: atomically replace route metadata during sync - #17096
Merged
elliott-with-the-longest-name-on-github merged 1 commit intoSep 14, 2026
Merged
elliott-with-the-longest-name-on-github merged 1 commit into
elliott-with-the-longest-name-on-github merged 1 commit into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/f87a22d80aea6de76eb77dd5cf4727efb9db300aOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: f87a22d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
elliott-with-the-longest-name-on-github
approved these changes
Sep 14, 2026
elliott-with-the-longest-name-on-github
marked this pull request as ready for review
September 14, 2026 22:09
elliott-with-the-longest-name-on-github
merged commit Sep 14, 2026
f8258ee
into
sveltejs:version-3
37 of 38 checks passed
4 of 6 tasks
Rich-Harris
pushed a commit
that referenced
this pull request
Oct 1, 2026
alternative to #17231 cc: @Nic-Polumeyv closes #17224 re-opens #17095 This PR reverts the code and test changes from #17096 We should probably find a different fix for #17095 --- ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. ### Tests - [ ] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. ### Edits - [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17095.
Concurrent syncs could read
route_meta_data.jsonwhile another process had truncated it for a direct rewrite. This caused intermittentJSON.parsefailures.This change:
finallyblockThe unique temporary name avoids collisions, while its location prevents another concurrent sync's types cleanup from removing an in-progress write.
Verification:
write_types/index.spec.jssuite (21 tests)pnpm -F @sveltejs/kit test:unit(783 passed)pnpm lintpnpm checkpnpm -F @sveltejs/kit prepublishOnlysvelte-kit syncprocesses (0 failures)