Skip to content

fix: preserve errors with read-only stacks - #17180

Merged
teemingc merged 2 commits into
sveltejs:version-3from
teemingc:teemingc-issue-17179
Sep 22, 2026
Merged

teemingc merged 2 commits into
sveltejs:version-3from
teemingc:teemingc-issue-17179

Conversation

@teemingc

@teemingc teemingc commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

closes #17179

Errors whose stack property is read-only were replaced by a TypeError when SvelteKit attempted to format their stack traces.

This PR makes stack replacement best-effort, preserving the original stack when it cannot be updated.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@pkg-svelte-dev

pkg-svelte-dev Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 15be300:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/15be3003950b626e512b813afd8452d3002260c5

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/17180

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

@changeset-bot

changeset-bot Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 15be300

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Nic-Polumeyv Nic-Polumeyv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@teemingc
teemingc merged commit 755024a into sveltejs:version-3 Sep 22, 2026
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors with read-only stack property swallowed by TypeError in 3.0.0-next.12 and above

2 participants