Skip to content

fix: restore scroll after BFCache returns - #17255

Merged
teemingc merged 5 commits into
version-3from
triage/kit-17249-ios-bfcache-scroll
Sep 29, 2026
Merged

teemingc merged 5 commits into
version-3from
triage/kit-17249-ios-bfcache-scroll

Conversation

@svelte-triage-bot

Copy link
Copy Markdown
Contributor
  • Kit keeps scroll restoration manual and saves the correct history-entry coordinates, but its persisted pageshow handler did not reapply them when iOS revived a BFCache document at the top.
  • #3938 established Kit-owned session-storage restoration, and #17244 removed the obsolete leave-time switch back to browser restoration.
  • Restore the current entry synchronously on persisted pageshow; toggling scrollRestoration to auto was rejected because it is timing-dependent and misses non-click departures.
  • Cover persisted and ordinary pageshow events without changing no-JS, reload, hash, or same-document popstate behavior.

Fixes #17249

@pkg-svelte-dev

pkg-svelte-dev Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from ac7cd27:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/ac7cd27c73d47bcc5ed4eecbd77b16d19a5ae461

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/17255

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

@changeset-bot

changeset-bot Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ac7cd27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

Comment thread packages/kit/src/runtime/client/client.js Outdated
Comment thread packages/kit/src/runtime/client/client.js
Comment thread packages/kit/test/apps/basics/test/playwright/cross-platform/client.test.js Outdated
@teemingc
teemingc marked this pull request as ready for review September 29, 2026 17:27
@teemingc
teemingc merged commit 846f3d4 into sveltejs:version-3 Sep 29, 2026
4 of 5 checks passed
Rich-Harris pushed a commit that referenced this pull request Sep 30, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to version-3, this PR
will be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`version-3` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `version-3`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @sveltejs/adapter-cloudflare@8.0.0-next.8

### Patch Changes

- fix: dispose the platform proxy when the Vite dev or preview server
closes ([#17238](#17238))
- Updated dependencies
[[`12ae0b9`](12ae0b9),
[`ee3332f`](ee3332f),
[`72832f9`](72832f9),
[`846f3d4`](846f3d4)]:
  - @sveltejs/kit@3.0.0-next.31
## @sveltejs/kit@3.0.0-next.31

### Patch Changes

- fix: resolve generated rootDirs from the project root
([#17242](#17242))

- fix: keep `history.scrollRestoration` set to `manual` when leaving the
page, so a document restored from the back/forward cache does not fall
back to browser scroll restoration
([#17244](#17244))

- fix: clear `navigating` when a shallow popstate aborts an in-flight
navigation ([#17118](#17118))

- fix: restore scroll position after back-forward cache returns
([#17255](#17255))

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iOS Safari returns to top after following external link and going Back

1 participant