Repository navigation
Merged
Conversation
added 3 commits
February 9, 2022 22:29
🦋 Changeset detectedLatest commit: 44c7e06 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✔️ Deploy Preview for kit-demo canceled. 🔨 Explore the source changes: 44c7e06 🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/62063a2de544bb0007f687e9 |
benmccann
reviewed
Feb 9, 2022
Member
|
lgtm. thanks for this! |
Member
|
I wonder if this would help #3649 too |
ghost
requested a review
from benmccann
February 10, 2022 21:46
benmccann
reviewed
Feb 10, 2022
ghost
requested a review
from benmccann
February 11, 2022 11:38
benmccann
approved these changes
Feb 13, 2022
This was referenced Feb 13, 2022
4 of 5 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
followup of #3798
moved JSON.stringify into
escape_json_in_htmland reused it in place of escape_json_value_in_htmlPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0