Skip to content

refactor: simplify escape_json_in_html util - #3804

Merged
benmccann merged 6 commits into
masterfrom
unknown repository
Feb 13, 2022
Merged

benmccann merged 6 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Feb 9, 2022

Copy link
Copy Markdown

followup of #3798

moved JSON.stringify into escape_json_in_html and reused it in place of escape_json_value_in_html

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot

changeset-bot Bot commented Feb 9, 2022 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 44c7e06

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Feb 9, 2022 •

Copy link
Copy Markdown

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 44c7e06

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/62063a2de544bb0007f687e9

Comment thread packages/kit/src/runtime/server/page/load_node.js Outdated
@benmccann

Copy link
Copy Markdown
Member

lgtm. thanks for this!

@bluwy

bluwy commented Feb 10, 2022

Copy link
Copy Markdown
Member

I wonder if this would help #3649 too

Comment thread packages/kit/src/runtime/server/page/load_node.js Outdated
@benmccann
benmccann merged commit 0c6bc25 into sveltejs:master Feb 13, 2022
This was referenced Feb 13, 2022
@PH4NTOMiki PH4NTOMiki mentioned this pull request Feb 20, 2022
4 of 5 tasks

This branch was successfully deployed

2 active deployments
Preview – kit-svelte-dev — 44c7e069 Deployed Feb 11, 2022 by vercel[bot]
Preview – kit — 44c7e069 Deployed Feb 11, 2022 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants