Skip to content

feat: upgrade to svelte-check v3 - #8468

Merged
Rich-Harris merged 2 commits into
masterfrom
svelte-check-v3
Jan 11, 2023
Merged

Rich-Harris merged 2 commits into
masterfrom
svelte-check-v3

Conversation

@dummdidumm

Copy link
Copy Markdown
Member

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot

changeset-bot Bot commented Jan 11, 2023 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 29191f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry

Copy link
Copy Markdown
Member

I think this sort of change to create-svelte should be at least a minor, not patch.

@dummdidumm

Copy link
Copy Markdown
Member Author

my bad, meant to make it a minor, thanks for catching that

@Rich-Harris
Rich-Harris merged commit 7214aaf into master Jan 11, 2023
@Rich-Harris
Rich-Harris deleted the svelte-check-v3 branch January 11, 2023 21:55
@github-actions github-actions Bot mentioned this pull request Jan 11, 2023

This branch was successfully deployed

2 active deployments
Preview – kit-svelte-dev — 29191f5f Deployed Jan 11, 2023 by vercel[bot]
Preview – kit — 29191f5f Deployed Jan 11, 2023 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants