Skip to content

fix: check version on node fetch fail - #8487

Merged
Rich-Harris merged 1 commit into
masterfrom
check-version
Jan 13, 2023
Merged

Rich-Harris merged 1 commit into
masterfrom
check-version

Conversation

@dummdidumm

Copy link
Copy Markdown
Member

possibly related to #7071
the "check if version updated" logic was only applied to data loading, not loading the node files itself

no test because I don't know how 😄 a good example where unit-testing this would help

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot

changeset-bot Bot commented Jan 12, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: dbb8fe7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Rich-Harris merged commit 40464ef into master Jan 13, 2023
@Rich-Harris
Rich-Harris deleted the check-version branch January 13, 2023 03:10
@github-actions github-actions Bot mentioned this pull request Jan 13, 2023
teemingc added a commit that referenced this pull request Oct 14, 2026
…17440)

- Service-worker lookup/update failures escape both deployment-recovery
paths and prevent full-document navigation.
- Retain the awaited refresh introduced in
[#12448](#12448) and documented in
[#16310](#16310); deleting or
fire-and-forgetting it loses the opportunity to install an updated
worker before reloading.
- Catch failures in the shared helper rather than individual callers;
preserve module-failure recovery
([#8487](#8487)), version gating
([#16496](#16496)), and
replacement-history semantics
([#14424](#14424)).
- Cover synchronous/rejected lookups, failed updates, missing
registrations, and successful-update sequencing in both route-load and
error-status recovery.

Fixes #17435

<!--
svelte-triage-bot:feedback-baseline:50cc6409e1816477e9f7fd0bb3702a95dc6b5e4f
-->

---------

Co-authored-by: svelte-triage-bot <team@svelte.com>
Co-authored-by: Tee Ming <chewteeming01@gmail.com>

This branch was successfully deployed

2 active deployments
Preview – kit-svelte-dev — dbb8fe7b Deployed Jan 12, 2023 by vercel[bot]
Preview – kit — dbb8fe7b Deployed Jan 12, 2023 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants