Repository navigation
fix: check version on node fetch fail - #8487
Merged
Merged
Conversation
possibly related to #7071
🦋 Changeset detectedLatest commit: dbb8fe7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
approved these changes
Jan 13, 2023
Merged
teemingc
added a commit
that referenced
this pull request
Oct 14, 2026
…17440) - Service-worker lookup/update failures escape both deployment-recovery paths and prevent full-document navigation. - Retain the awaited refresh introduced in [#12448](#12448) and documented in [#16310](#16310); deleting or fire-and-forgetting it loses the opportunity to install an updated worker before reloading. - Catch failures in the shared helper rather than individual callers; preserve module-failure recovery ([#8487](#8487)), version gating ([#16496](#16496)), and replacement-history semantics ([#14424](#14424)). - Cover synchronous/rejected lookups, failed updates, missing registrations, and successful-update sequencing in both route-load and error-status recovery. Fixes #17435 <!-- svelte-triage-bot:feedback-baseline:50cc6409e1816477e9f7fd0bb3702a95dc6b5e4f --> --------- Co-authored-by: svelte-triage-bot <team@svelte.com> Co-authored-by: Tee Ming <chewteeming01@gmail.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
possibly related to #7071
the "check if version updated" logic was only applied to data loading, not loading the node files itself
no test because I don't know how 😄 a good example where unit-testing this would help
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.