Repository navigation
inotify: fix recursive directory rename handling - #5
Open
allenanswerzq wants to merge 1 commit into
Open
allenanswerzq wants to merge 1 commit into
allenanswerzq wants to merge 1 commit into
Conversation
Author
|
this pr should also fix this syncthing/syncthing#7950 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Linux recursive-watcher failure described in rjeczalik#227 for the Syncthing fork.
Recursive watches maintain an internal tree of per-directory inotify watches. Directory removal, recreation, and rename events could be processed out of order, leaving watch descriptors associated with stale paths. Subsequent file events could therefore report the previous path or be dropped entirely.
This change:
Verification:
go test ./...go test -race ./...TestRecreatedpassed 30 repeated runsWithout the fix, the new regression tests consistently report events using the stale
temporary/filepath instead oforiginal/file.