Conversation
jimmeryn
marked this pull request as ready for review
September 24, 2026 14:05
jimmeryn
requested review from
librowski,
lukasz-jazwa,
piotrblaszczyk and
szymon-t-sc
as code owners
September 24, 2026 14:05
…ision, locked until Reset
…ction The fields control renders the UI Accordion itself instead of a plain label, so the whole section, header included, steps aside while the node waits. contain: inline-size keeps long field names from widening the accordion's grid past the panel. The hint takes the mockup's copy and grey block, and shows only when no edge comes into the node.
jimmeryn
force-pushed
the
feat/WB-648-decision-fields-control
branch
from
September 25, 2026 15:38
99519e3 to
f7f1aee
Compare
jimmeryn
changed the base branch from
feat/WB-642-decision-form
to
feat/human-in-the-loop
September 25, 2026 15:39
…change under it WB-648 With the app bar's read-only switch lifted, undo can change the picks while the node waits. The open form now keeps the schema and proposal it opened with and measures the edits against them; reopened under changed picks, a field turned read-only shows the proposal instead of the draft. The settled record follows the current picks. Editable and required drops null from a nullable type, so a null the model left holds Approve back. The README bullet is split and says where a hidden value is still visible.
WB-648 FieldModeRow takes the mode labels, the Select items and its row styles with it, matching how decision-form keeps one component per file. The control keeps the store wiring, the accordion and the hint.
jimmeryn
force-pushed
the
feat/WB-648-decision-fields-control
branch
from
September 25, 2026 17:18
87c5b36 to
9254217
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WB-648
What
The Human decision properties panel lists the fields the proposal source declares in
properties.outputSchema. The author sets each one to Hidden, Read-only, Editable, or Editable and required.Decisions
decisionRequest.schemaitself, in the contract's format: a field it leaves out is Hidden. The canvas, the Run payload and the decider's form read one schema, so the backend needs no change.