Skip to content

refactor: unify account info error boundary#97

Merged
ovitrif merged 1 commit into
masterfrom
ovi/refactor-unify-account-info-error-boundary
Jun 4, 2026
Merged

refactor: unify account info error boundary#97
ovitrif merged 1 commit into
masterfrom
ovi/refactor-unify-account-info-error-boundary

Conversation

@ovitrif

@ovitrif ovitrif commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Closes #96

Description

This PR applies the run_account_info_blocking boundary from the address-info hotfix to the remaining onchain BDK/Electrum paths that return AccountInfoError:

  • get_account_info
  • get_transaction_history
  • get_transaction_detail
  • compose_transaction

Inner typed AccountInfoError values are preserved, while blocking-task panics and join failures now return AccountInfoError::SyncError through the same helper used by get_address_info.

Release:

Preview

N/A, native library change.

QA Notes

Automated Tests

  • cargo fmt --check
  • cargo test account_info_blocking_task -- --nocapture
  • cargo test compose_empty_fee_rates -- --nocapture
  • cargo test get_transaction_history_invalid_key -- --nocapture
  • cargo test get_transaction_history_network_mismatch -- --nocapture
  • cargo test get_transaction_detail_invalid_key -- --nocapture
  • cargo test get_transaction_detail_invalid_txid -- --nocapture
  • cargo test get_transaction_detail_network_mismatch -- --nocapture
  • cargo test get_account_info_invalid_key -- --nocapture
  • cargo test get_account_info_network_mismatch -- --nocapture
  • cargo test --lib -- --skip modules::blocktank
  • cargo clippy (passes with existing warnings)
  • ./build.sh -r --patch all
  • ./build.sh all
  • swift package compute-checksum bindings/ios/BitkitCore.xcframework.zip

Release Notes

  • Bumped bitkit-core to 0.1.68.
  • Regenerated Android, iOS, and Python native artifacts.
  • Published v0.1.68 at 75bf69e;

@ovitrif ovitrif force-pushed the ovi/refactor-unify-account-info-error-boundary branch from 53e3837 to 75bf69e Compare June 4, 2026 16:10
@ovitrif ovitrif marked this pull request as ready for review June 4, 2026 16:45
@ovitrif ovitrif requested review from ben-kaufman and coreyphillips and removed request for ben-kaufman June 4, 2026 16:45
@ovitrif ovitrif self-assigned this Jun 4, 2026
@ovitrif ovitrif merged commit 5bf94f6 into master Jun 4, 2026
1 check passed
@ovitrif ovitrif deleted the ovi/refactor-unify-account-info-error-boundary branch June 4, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: Unify error boundary for account-info blocking work

2 participants