refactor: unify account info error boundary#97
Merged
Conversation
53e3837 to
75bf69e
Compare
ben-kaufman
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #96
Description
This PR applies the
run_account_info_blockingboundary from the address-info hotfix to the remaining onchain BDK/Electrum paths that returnAccountInfoError:get_account_infoget_transaction_historyget_transaction_detailcompose_transactionInner typed
AccountInfoErrorvalues are preserved, while blocking-task panics and join failures now returnAccountInfoError::SyncErrorthrough the same helper used byget_address_info.Release:
Preview
N/A, native library change.
QA Notes
Automated Tests
cargo fmt --checkcargo test account_info_blocking_task -- --nocapturecargo test compose_empty_fee_rates -- --nocapturecargo test get_transaction_history_invalid_key -- --nocapturecargo test get_transaction_history_network_mismatch -- --nocapturecargo test get_transaction_detail_invalid_key -- --nocapturecargo test get_transaction_detail_invalid_txid -- --nocapturecargo test get_transaction_detail_network_mismatch -- --nocapturecargo test get_account_info_invalid_key -- --nocapturecargo test get_account_info_network_mismatch -- --nocapturecargo test --lib -- --skip modules::blocktankcargo clippy(passes with existing warnings)./build.sh -r --patch all./build.sh allswift package compute-checksum bindings/ios/BitkitCore.xcframework.zipRelease Notes
bitkit-coreto0.1.68.v0.1.68at75bf69e;